Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group alias references #39

Closed
wants to merge 3 commits into from
Closed

Group alias references #39

wants to merge 3 commits into from

Conversation

tschlaepfer
Copy link

Description of your changes

This MR enables referencing group id and auth backends in group aliases allowing for a more dynamic configuration of the OIDC setting in HashiCorp Vault.

Fixes #36

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

This MR has been tested by running "make run" against a local cluster where a group alias manifest that made use of the new canonicalIdRef and mountAccessorRef parameters.

apiVersion: identity.vault.upbound.io/v1alpha1
kind: GroupAlias
metadata:
  labels:
    testing.upbound.io/example-name: oidc-developer-group-alias
  name: oidc-developer-group-alias
  namespace: vault
spec:
  forProvider:
    name: vault-developer
    canonicalIdRef:
      name: oidc-developer-group
    mountAccessorRef:
      name: oidc-backend
  providerConfigRef:
    name: vault-provider

image

Tobias Schlaepfer added 3 commits May 27, 2024 14:31
update config.go to enable group alias references
d5ad30e 
Signed-off-by: Tobias Schlaepfer <[email protected]>
add common accessor func
e6d66a8 
Signed-off-by: Tobias Schlaepfer <[email protected]>
update crd manifests
0e29e68 
Signed-off-by: Tobias Schlaepfer <[email protected]>
@tschlaepfer
Copy link
Author

The implementation of the reference to the mountAccessor is right now not possible as outlined in the following upjet issue: crossplane/upjet#95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulucinar ulucinar Awaiting requested review from ulucinar ulucinar will be requested when the pull request is marked ready for review ulucinar is a code owner

@sergenyalcin sergenyalcin Awaiting requested review from sergenyalcin sergenyalcin will be requested when the pull request is marked ready for review sergenyalcin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference Accessor of oidc auth backend in groupAlias
1 participant
@tschlaepfer